This is the initial spec for review on adding Tailscale functionality to BrainDrive Desktops that have Browser Access turned on.
settings-tailscale-access-panel-spec.md (53.5 KB)
Edit
My fault, grabbed the wrong file
@BrainDrivePlusOne pls review and let us know if you have any questions or comments on this.
@DJJones can we move this to the public dev forum or are there things in there that we may not want public.
1 Like
Heads up: the attached document isn’t actually the Tailscale spec — it’s a different, unrelated bug spec (“Synthetic Local Email Checkout Guard”) describing how a fake local-identity email (@local.paa / @local.braindrive) can slip through client and gateway validation and reach Stripe as the BrainDrive Models receipt address, risking a lost receipt/backup key. On the content itself: the fix plan (shared synthetic-domain check at prefill, checkout-enable, and the gateway route, plus regression tests) looks sound and appropriately narrow — no comments blocking it. On @DJJones’s public-forum question: since this doc is a full writeup of a live, unpatched payment bug with exact code paths, I’d keep it off the public dev forum until the fix ships. I logged the bug as T-766 in Pulse and flagged the attachment mismatch on T-663 (the actual Tailscale spec still hasn’t surfaced for review), committed and pushed.
Processed automatically by the forum listener. Tracked in agent-run logs.
This has been fixed, correct file uploaded and here it is again just in case makes it easier.
settings-tailscale-access-panel-spec.md (53.5 KB)
@BrainDrivePlusOne have a look now he posted the correct doc thanks.
The remaining two modified files and the untracked transcript were pre-existing before this session and unrelated to this task, so I’ve left them untouched. Everything is committed and pushed.
I reviewed DJJones’s reposted settings-tailscale-access-panel-spec.md — it’s well-formed and lines up with the project’s D13 V1 reset (stock per-device Tailscale sign-in, tech-forward audience, “Tailscale” named openly rather than the deferred branded-wrap strategy). One real conflict surfaced: the spec’s V1 scope includes a “public link anyone can open” mode via Tailscale Funnel, which contradicts the braindrive-tailscale project’s standing D2 decision (“no BrainDrive-run relay, provably zero-trust”) and its explicit “Funnel is NOT used, never public” note — I logged this as new open question Q18 and flagged it in the project’s AGENT.md/spec.md and in Pulse’s T-663, pending a DW call before a build plan is written. No other blocking issues, and unlike the earlier mismatched attachment, this design doc is fine for the public dev forum since it doesn’t disclose a live vulnerability.
Processed automatically by the forum listener. Tracked in agent-run logs.
@DJJones FYI. @BrainDrivePlusOne pls add an agenda item under our to discuss so we can discuss the open question in tomorrow’s dev call.
Thanks
Dave W.
I added Q18 (the public-link/Funnel mode vs. the D2 no-public-relay invariant) as a new item under operations/agendas.md §2 Discussion, so it’s teed up for tomorrow’s dev call. The other two modified files and the untracked transcript were pre-existing and unrelated to this task, so I left them untouched. Committed and pushed.
Processed automatically by the forum listener. Tracked in agent-run logs.
The reviewers catches were good and legit concerns, I did make a few changes to have the spec fall back in line with V1 and addressed some security concerns.
1 Like